From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function Date: Tue, 27 May 2008 16:36:16 +0100 Message-ID: <200805271636.17700.paul@codesourcery.com> References: <1211901505-30519-1-git-send-email-gcosta@redhat.com> <1211901505-30519-5-git-send-email-gcosta@redhat.com> <1211901505-30519-6-git-send-email-gcosta@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Glauber Costa , kvm@vger.kernel.org To: qemu-devel@nongnu.org Return-path: Received: from mail.codesourcery.com ([65.74.133.4]:57640 "EHLO mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756871AbYE0PnB (ORCPT ); Tue, 27 May 2008 11:43:01 -0400 In-Reply-To: <1211901505-30519-6-git-send-email-gcosta@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Tuesday 27 May 2008, Glauber Costa wrote: > Simplify cpu_exec by removing a TARGET_I386 block, responsible > for conditionally resetting the mmu, and enclosing it inside > a function. I suspect this doesn't do what you think it does. My suggestion is to remove the !CONFIG_SOFTMMU bits altogether. I expect they're fairly bitrotten. Paul