From: Jens Axboe <jens.axboe@oracle.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH/RFC] virtio_blk: check for hardsector size from host
Date: Thu, 29 May 2008 10:13:57 +0200 [thread overview]
Message-ID: <20080529081357.GP25504@kernel.dk> (raw)
In-Reply-To: <20080529081255.GO25504@kernel.dk>
On Thu, May 29 2008, Jens Axboe wrote:
> On Thu, May 29 2008, Rusty Russell wrote:
> > On Tuesday 27 May 2008 19:04:59 Christian Borntraeger wrote:
> > > Rusty, Jens,
> > >
> > > I need your opinion on the following patch. It seems to work, but I would
> > > like to get some feedback if this patch is the right approach:
> >
> > Looks like the right approach to me. Don't know about the block side
> > of it...
>
> Looks good to me, definitely an improvement for eg loop backed
> storage.
>
> > Just that u64 seems like overkill: u32?
>
> Definitely, u32 would be just fine, u64 is way overkill :-)
Even u16 would work, the block layer doesn't use more than an unsigned
short for storing hardware sector size anyway.
--
Jens Axboe
next prev parent reply other threads:[~2008-05-29 8:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 9:04 [PATCH/RFC] virtio_blk: check for hardsector size from host Christian Borntraeger
2008-05-29 8:04 ` Rusty Russell
2008-05-29 8:11 ` Christian Borntraeger
2008-05-29 8:12 ` Jens Axboe
2008-05-29 8:13 ` Jens Axboe [this message]
2008-05-29 8:27 ` Christian Borntraeger
2008-05-29 8:30 ` Jens Axboe
2008-05-29 9:08 ` [PATCH] virtio_config: fix len calculation of config elements Christian Borntraeger
2008-05-30 3:18 ` Rusty Russell
2008-05-29 9:08 ` [PATCH v2] virtio_blk: check for hardsector size from host Christian Borntraeger
2008-05-30 3:41 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529081357.GP25504@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox