Re: [PATCH/RFC] virtio_blk: check for hardsector size from host

Christian Borntraeger
2008-05-29T08:28:59Z

Am Donnerstag, 29. Mai 2008 schrieb Jens Axboe:
> > > Just that u64 seems like overkill: u32?
> >
> > Definitely, u32 would be just fine, u64 is way overkill :-)
>
> Even u16 would work, the block layer doesn't use more than an unsigned
> short for storing hardware sector size anyway.

Thanks, good to know. Do you think, that could change in the future? The
virtio definition is going to be a public interface, so if there is a chance
that u16 is not enough in the future I would respin the patch with u32,
otherwise u16.

Christian