Re: [PATCH/RFC] virtio_blk: check for hardsector size from host

Christian Borntraeger
2008-05-29T08:11:40Z

Am Donnerstag, 29. Mai 2008 schrieb Rusty Russell:
> On Tuesday 27 May 2008 19:04:59 Christian Borntraeger wrote:
> > Rusty, Jens,
> >
> > I need your opinion on the following patch. It seems to work, but I would
> > like to get some feedback if this patch is the right approach:
>
> Looks like the right approach to me. Don't know about the block side of
it...
>
> Just that u64 seems like overkill: u32?

I looked at blksize_t, which seems to be long. So I decided to use u64 which
should be enough (but still overkill...) on all platforms.

While we are at it. Since we dont convert endianess any longer, should I
change all the __le{..} definitions to __u{..} in virtio_blk.h ?

Christian