From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH/RFC] virtio_blk: check for hardsector size from host Date: Thu, 29 May 2008 18:04:11 +1000 Message-ID: <200805291804.11550.rusty@rustcorp.com.au> References: <200805271105.00077.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Jens Axboe , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org To: Christian Borntraeger Return-path: Received: from ozlabs.org ([203.10.76.45]:40779 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbYE2IEW (ORCPT ); Thu, 29 May 2008 04:04:22 -0400 In-Reply-To: <200805271105.00077.borntraeger@de.ibm.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Tuesday 27 May 2008 19:04:59 Christian Borntraeger wrote: > Rusty, Jens, > > I need your opinion on the following patch. It seems to work, but I would > like to get some feedback if this patch is the right approach: Looks like the right approach to me. Don't know about the block side of it... Just that u64 seems like overkill: u32? Cheers, Rusty.