From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH v2] virtio_blk: check for hardsector size from host Date: Fri, 30 May 2008 13:41:45 +1000 Message-ID: <200805301341.46175.rusty@rustcorp.com.au> References: <200805271105.00077.borntraeger@de.ibm.com> <20080529083004.GQ25504@kernel.dk> <200805291108.26375.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Jens Axboe , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org To: Christian Borntraeger Return-path: Received: from ozlabs.org ([203.10.76.45]:53233 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbYE3Dma (ORCPT ); Thu, 29 May 2008 23:42:30 -0400 In-Reply-To: <200805291108.26375.borntraeger@de.ibm.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Thursday 29 May 2008 19:08:26 Christian Borntraeger wrote: > Currently virtio_blk assumes a 512 byte hard sector size. This can cause > trouble / performance issues if the backing has a different block size > (like a file on an ext3 file system formatted with 4k block size or a > dasd). > > Lets add a feature flag that tells the guest to use a different hard sector > size than 512 byte. > > Signed-off-by: Christian Borntraeger Thanks. I've queued this for next kernel (the other two will go striaght-away). Cheers, Rusty.