* allow kprobes to run on top of preempt emulation
@ 2008-06-04 23:09 Andrea Arcangeli
2008-06-05 7:06 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Andrea Arcangeli @ 2008-06-04 23:09 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm
This patch makes preempt emulation more strict in differentiating its
own dr0 hardware breakpoint from a singlestep in return from kprobes
pre-handler that will invoke the post-handler through int1 debug TS on
eflags. This avoids GPF when kprobes returns from pre-handler with the
dr7 loaded with preempt emulation.
Signed-off-by: Andrea Arcangeli <andrea@qumranet.com>
--- kvm-userland/kernel/preempt.c 2008-05-06 19:33:40.000000000 +0200
+++ /home/andrea/kernel/qumranet/kvm/kernel/preempt.c 2008-06-05 00:18:06.000000000 +0200
@@ -140,6 +147,11 @@
"cmp $0x701, " TMP " \n\t"
"pop " TMP " \n\t"
"jnz .Lnotme \n\t"
+ "push " TMP " \n\t"
+ "mov %db6, " TMP " \n\t"
+ "test $0x1, " TMP " \n\t"
+ "pop " TMP " \n\t"
+ "jz .Lnotme \n\t"
SAVE_REGS "\n\t"
#ifdef CONFIG_X86_64
"leaq 120(%rsp),%rdi\n\t"
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: allow kprobes to run on top of preempt emulation
2008-06-04 23:09 allow kprobes to run on top of preempt emulation Andrea Arcangeli
@ 2008-06-05 7:06 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-06-05 7:06 UTC (permalink / raw)
To: Andrea Arcangeli; +Cc: kvm
Andrea Arcangeli wrote:
> This patch makes preempt emulation more strict in differentiating its
> own dr0 hardware breakpoint from a singlestep in return from kprobes
> pre-handler that will invoke the post-handler through int1 debug TS on
> eflags. This avoids GPF when kprobes returns from pre-handler with the
> dr7 loaded with preempt emulation.
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-05 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-04 23:09 allow kprobes to run on top of preempt emulation Andrea Arcangeli
2008-06-05 7:06 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox