Re: KVM: MMU: rmap_write_protect() hugepage iteration bug

Avi Kivity
2008-06-08T08:04:21Z

Avi Kivity wrote:
> Avi Kivity wrote:
>> Marcelo Tosatti wrote:
>>> How bad you think restarting is? Unless there are workloads with very
>>> large hugepage chains most of the data should be cached in L1. Also the
>>> fact that a 4K page has just been shadowed inside a large region makes
>>> it unlikely for the same chain to be examined again soon.
>>>
>>
>> Non-pae guests will have a chain entry for every mm_struct, since the
>> large ptes reside in the pgd and that is replicated for every
>> mm_struct. So it's easy to have very long chains.
>>
>>
>
> Anyway I applied the patch as a stopgap.
>

btw, please send a signoff for 2.6.26.

--
error compiling committee.c: too many arguments to function