From: Marcelo Tosatti <mtosatti@redhat.com>
To: Andrea Arcangeli <andrea@qumranet.com>
Cc: Avi Kivity <avi@qumranet.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: KVM: MMU: rmap_write_protect() hugepage iteration bug
Date: Sun, 8 Jun 2008 21:20:41 -0300 [thread overview]
Message-ID: <20080609002041.GA5100@dmt.cnet> (raw)
In-Reply-To: <20080608203037.GB9921@duo.random>
On Sun, Jun 08, 2008 at 10:30:37PM +0200, Andrea Arcangeli wrote:
> On Sun, Jun 08, 2008 at 04:52:15PM -0300, Marcelo Tosatti wrote:
> > We do. The case is were you have two entries in the array. rmap_remove
> > will first remove the entry at index 0, and move the entry at index 1 to
> > 0.
> >
> > Then we call "rmap_next()" with a non-NULL spte, which will skip the
> > only remaining entry at index 0. IOW rmap_next() requires the spte
> > argument to be NULL if the array has one valid entry.
>
> How exactly we could call rmap_next with not-NULL spte after any
> rmap_remove with your last patch applied?
With the original code.
next prev parent reply other threads:[~2008-06-09 0:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 0:27 KVM: MMU: rmap_write_protect() hugepage iteration bug Marcelo Tosatti
2008-06-08 1:54 ` Andrea Arcangeli
2008-06-08 4:48 ` Marcelo Tosatti
2008-06-08 7:30 ` Avi Kivity
2008-06-08 8:03 ` Avi Kivity
2008-06-08 8:04 ` Avi Kivity
2008-06-08 18:31 ` Andrea Arcangeli
2008-06-08 19:52 ` Marcelo Tosatti
2008-06-08 20:30 ` Andrea Arcangeli
2008-06-09 0:20 ` Marcelo Tosatti [this message]
2008-06-09 0:55 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609002041.GA5100@dmt.cnet \
--to=mtosatti@redhat.com \
--cc=andrea@qumranet.com \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox