From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Xu, Anthony" <anthony.xu@intel.com>
Cc: Avi Kivity <avi@qumranet.com>, Jes Sorensen <jes@sgi.com>,
kvm@vger.kernel.org, kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] kvm-ia64 irq assignment 2/2 userspace
Date: Wed, 11 Jun 2008 15:58:37 -0300 [thread overview]
Message-ID: <20080611185837.GA13245@dmt.cnet> (raw)
In-Reply-To: <20080611165441.GA7926@dmt.cnet>
> > @@ -220,6 +232,11 @@ static void piix3_set_irq(qemu_irq *pic, int
> > irq_num, int level)
> > {
> > int i, pic_irq, pic_level;
> >
> > +#if defined(KVM_CAP_IRQCHIP) && defined(TARGET_IA64)
> > + if(kvm_enabled())
> > + kvm_set_irq(irq_num, level);
> > + return;
> > +#endif
> > pci_irq_levels[irq_num] = level;
>
> Why the current hook into i8259_set_irq does not work for IA64?
if (pic_irq < 16) {
/* The pic level is the logical OR of all the PCI irqs mapped
to it */
Ok, but still, how can you share interrupts by directly changing the
level without checking for individual devices first.
> I think this breaks interrupt sharing, because the logic to detect if
> all devices sharing the line are low or high is in i8259_set_irq, and
s/i8259_set_irq/piix3_set_irq/
> you simply skip that.
prev parent reply other threads:[~2008-06-11 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 15:59 [PATCH] kvm-ia64 irq assignment 2/2 userspace Xu, Anthony
2008-06-11 16:54 ` Marcelo Tosatti
2008-06-11 18:58 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080611185837.GA13245@dmt.cnet \
--to=mtosatti@redhat.com \
--cc=anthony.xu@intel.com \
--cc=avi@qumranet.com \
--cc=jes@sgi.com \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox