public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Oliver Paukstadt <pstadt@sourcentral.org>
Cc: Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org
Subject: Re: [RFC] kvm-s390: userspace snapshot
Date: Thu, 12 Jun 2008 00:14:36 +0200	[thread overview]
Message-ID: <200806120014.36551.borntraeger@de.ibm.com> (raw)
In-Reply-To: <1213217605.3120.41.camel@nerve>

Am Mittwoch, 11. Juni 2008 schrieb Oliver Paukstadt:
> 00 01213216145:212946 3 - 03 000003e0004e9a36  vm created
> 00 01213216145:213593 3 - 00 000003e0004e90d8  create cpu 0 at
> 000000001ca46400, sie block at 000000001faf9000
> 00 01213216145:237824 2 - 00 000003e0004e9dcc
> 00[0000000180000000-0000000000010000]: unhandled validity intercept 
> code 61

Ok, I got an idea.
Does that patch fix the handle_should_not_happen PANIC?

---
 arch/s390/kvm/kvm-s390.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Index: kvm/arch/s390/kvm/kvm-s390.c
===================================================================
--- kvm.orig/arch/s390/kvm/kvm-s390.c
+++ kvm/arch/s390/kvm/kvm-s390.c
@@ -250,10 +250,13 @@ static void kvm_s390_vcpu_initial_reset(
 	vcpu->arch.sie_block->gbea = 1;
 }
 
+/* some random value for testing */
+#define VIRTIODESCSPACE (100ul*1024ul*1024ul)
+
 int kvm_arch_vcpu_setup(struct kvm_vcpu *vcpu)
 {
 	atomic_set(&vcpu->arch.sie_block->cpuflags, CPUSTAT_ZARCH);
-	vcpu->arch.sie_block->gmslm = 0xffffffffffUL;
+	vcpu->arch.sie_block->gmslm = vcpu->kvm->arch.guest_memsize + VIRTIODESCSPACE -1;
 	vcpu->arch.sie_block->gmsor = vcpu->kvm->arch.guest_origin;
 	vcpu->arch.sie_block->ecb   = 2;
 	vcpu->arch.sie_block->eca   = 0xC1002001U;

  reply	other threads:[~2008-06-11 22:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06 15:54 [RFC] kvm-s390: userspace snapshot Carsten Otte
2008-06-10  5:55 ` Oliver Paukstadt
2008-06-11 14:35   ` Christian Borntraeger
2008-06-11 20:53     ` Oliver Paukstadt
2008-06-11 22:14       ` Christian Borntraeger [this message]
2008-06-12  5:39         ` Oliver Paukstadt
2008-06-12 14:14           ` Christian Borntraeger
2008-06-12 19:56             ` Oliver Paukstadt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806120014.36551.borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=cotte@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=pstadt@sourcentral.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox