Re: [RFC] kvm-s390: userspace snapshot

[Christian Borntraeger <borntraeger@de.ibm.com>]

Am Donnerstag, 12. Juni 2008 schrieb Oliver Paukstadt:
> On Thu, 2008-06-12 at 00:14 +0200, Christian Borntraeger wrote:
> 
> > Ok, I got an idea.
> > Does that patch fix the handle_should_not_happen PANIC?
> > 
> Patch does not fit, because my code contains
>  vcpu->arch.sie_block->gmsor = 0x000000000000;
> so I changed this before I applied the patch.
> The console patch you mentioned was applied too.
> 
> Now I am able to get the kernel running a little further:

good. I will make this patch proper and send it to Avi.

> PID hash table entries: 256 (order: 8, 2048 bytes)
> console [hvc0] enabled
> sclp vt220 tty driver: could not register vt220 - sclp_register returned
> -5
> list_del corruption. prev->next should be 00000000003d72a8, but was

Yes, Carsten ran into that as well, when we changed from vt220 to 
virtio_console. Looks like the vt220 driver doesnt like it, when there is no 
sclp available.

A fix is upstream in Linus git since yesterday:

commit 7b439d25300dc59bba76b53eb344bb9e5a1133f2
Author: Carsten Otte <cotte@de.ibm.com>
Date:   Tue Jun 10 10:03:22 2008 +0200

    [S390] vt220 console, initialize list head before use
[...]

diff --git a/drivers/s390/char/sclp_vt220.c b/drivers/s390/char/sclp_vt220.c
index 62576af..3e577f6 100644
--- a/drivers/s390/char/sclp_vt220.c
+++ b/drivers/s390/char/sclp_vt220.c
@@ -773,6 +773,7 @@ sclp_vt220_con_init(void)
 {
 	int rc;
 
+	INIT_LIST_HEAD(&sclp_vt220_register.list);
 	if (!CONSOLE_IS_SCLP)
 		return 0;
 	rc = __sclp_vt220_init();