public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: [patch 6/7] kvm: qemu: enable in-kernel C2 emulation / userspace emulation
Date: Wed, 18 Jun 2008 13:42:11 -0300	[thread overview]
Message-ID: <20080618164854.725255231@localhost.localdomain> (raw)
In-Reply-To: 20080618164205.108219607@localhost.localdomain

[-- Attachment #1: inkernel-acpic2-enable --]
[-- Type: text/plain, Size: 3414 bytes --]

Enable the in-kernel C2 emulation after the _CST notification has been
triggered.

Emulate in userspace for -no-kvm-irqchip case.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Index: kvm-userspace.tip/qemu/hw/acpi.c
===================================================================
--- kvm-userspace.tip.orig/qemu/hw/acpi.c
+++ kvm-userspace.tip/qemu/hw/acpi.c
@@ -124,6 +124,7 @@ static void pm_tmr_timer(void *opaque)
  * Fake C2 emulation, so the OS will consider the TSC unreliable
  * and fallback to C1 after the latency is updated to a high value
  * in acpi-dsdt.dsl.
+ * We still emulate C2 halt in case the OS ignores the _CST notification.
  */
 static void qemu_system_cpu_power_notify(void);
 static uint32_t pm_ioport_readb(void *opaque, uint32_t addr)
@@ -131,7 +132,12 @@ static uint32_t pm_ioport_readb(void *op
     addr &= 0x3f;
     switch (addr) {
     case 0x14: /* P_LVL2 */
-         qemu_system_cpu_power_notify();
+        if (!cst_notified)
+            qemu_system_cpu_power_notify();
+            cst_notified = 1;
+         } else {
+            qemu_kvm_handle_plvl2_read();
+         }
     }
 #ifdef DEBUG
     printf("pm_ioport_readb addr=%x\n", addr);
@@ -791,10 +797,12 @@ void qemu_system_cpu_hot_add(int cpu, in
 
 static void qemu_system_cpu_power_notify(void)
 {
-    power_gpe.disable = 1;
+    if (kvm_irqchip_in_kernel(kvm_context)) {
+        power_gpe.disable = 1;
 
-    qemu_set_irq(pm_state->irq, 1);
-    qemu_set_irq(pm_state->irq, 0);
+        qemu_set_irq(pm_state->irq, 1);
+        qemu_set_irq(pm_state->irq, 0);
+    }
 }
 
 #endif
Index: kvm-userspace.tip/qemu/qemu-kvm-x86.c
===================================================================
--- kvm-userspace.tip.orig/qemu/qemu-kvm-x86.c
+++ kvm-userspace.tip/qemu/qemu-kvm-x86.c
@@ -287,6 +287,21 @@ void kvm_load_mpstate(CPUState *env)
 #endif
 }
 
+uint32_t qemu_kvm_handle_plvl2_read(void)
+{
+    CPUState *env = cpu_single_env;
+    uint32_t ret;
+
+    if (kvm_irqchip_in_kernel(kvm_context)) {
+        kvm_enable_acpi_c2(kvm_context);
+        ret = 0;
+    } else {
+        kvm_arch_halt(NULL, env->cpu_index);
+        ret = 1;
+    }
+    return ret;
+}
+
 void kvm_arch_save_regs(CPUState *env)
 {
     struct kvm_regs regs;
Index: kvm-userspace.tip/qemu/qemu-kvm.h
===================================================================
--- kvm-userspace.tip.orig/qemu/qemu-kvm.h
+++ kvm-userspace.tip/qemu/qemu-kvm.h
@@ -88,6 +88,9 @@ void qemu_kvm_system_reset_request(void)
 int handle_powerpc_dcr_read(int vcpu, uint32_t dcrn, uint32_t *data);
 int handle_powerpc_dcr_write(int vcpu,uint32_t dcrn, uint32_t data);
 #endif
+#if defined(TARGET_I386) || defined(TARGET_X86_64) || defined (TARGET_IA64)
+uint32_t qemu_kvm_handle_plvl2_read(void);
+#endif
 
 #if !defined(SYS_signalfd)
 struct signalfd_siginfo {
Index: kvm-userspace.tip/qemu/qemu-kvm.c
===================================================================
--- kvm-userspace.tip.orig/qemu/qemu-kvm.c
+++ kvm-userspace.tip/qemu/qemu-kvm.c
@@ -619,6 +619,12 @@ static int kvm_debug(void *opaque, int v
 static int kvm_inb(void *opaque, uint16_t addr, uint8_t *data)
 {
     *data = cpu_inb(0, addr);
+    /*
+     * reads from the ACPI LVL2 port are similar to HLT emulation,
+     * so make current thread go sleep in main_loop().
+     */
+    if (addr == 0xb014 && *data)
+        return 1;
     return 0;
 }
 

-- 


  parent reply	other threads:[~2008-06-18 16:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18 16:42 [patch 0/7] force the TSC unreliable by reporting C2 state Marcelo Tosatti
2008-06-18 16:42 ` [patch 1/7] kvm: qemu: inform valid C2 state in ACPI table Marcelo Tosatti
2008-06-18 16:42 ` [patch 2/7] kvm: qemu: disable c2 via _CST notification Marcelo Tosatti
2008-06-18 16:42 ` [patch 3/7] libkvm: in-kernel C2 halt interface Marcelo Tosatti
2008-06-18 16:42 ` [patch 4/7] libkvm: handle_io return handler value Marcelo Tosatti
2008-06-18 16:42 ` [patch 5/7] qemu: kvm: unhalt vcpu0 on pit irq Marcelo Tosatti
2008-06-18 16:42 ` Marcelo Tosatti [this message]
2008-06-18 16:42 ` [patch 7/7] KVM: in-kernel ACPI C2 idle emulation Marcelo Tosatti
2008-06-23  3:01   ` Avi Kivity
2008-06-18 20:09 ` [patch 0/7] force the TSC unreliable by reporting C2 state Anthony Liguori
2008-06-18 20:40   ` Marcelo Tosatti
2008-06-18 21:02     ` Anthony Liguori
2008-06-18 21:21       ` Marcelo Tosatti
2008-06-18 21:42         ` Anthony Liguori
2008-06-18 22:41           ` Marcelo Tosatti
2008-06-18 22:57             ` john stultz
2008-06-18 23:08               ` Nakajima, Jun
2008-06-20 14:07             ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080618164854.725255231@localhost.localdomain \
    --to=mtosatti@redhat.com \
    --cc=avi@qumranet.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox