From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: RFC: cache_regs in kvm_emulate_pio
Date: Sun, 22 Jun 2008 15:05:07 -0300
Message-ID: <20080622180507.GA12595@dmt.cnet>
References: <20080621194639.GA15032@dmt.cnet> <485DE023.4060006@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm-devel <kvm@vger.kernel.org>
To: Avi Kivity <avi@qumranet.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([66.187.233.31]:49665 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752335AbYFVSF3 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 22 Jun 2008 14:05:29 -0400
Content-Disposition: inline
In-Reply-To: <485DE023.4060006@qumranet.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Jun 22, 2008 at 08:16:19AM +0300, Avi Kivity wrote:
> Looks good, but we can aim higher.  The cache_regs() API was always  
> confusing (I usually swap the two parts).  If we replace all ->regs  
> access with accessors, we can make it completely transparent.
>
> It will be tricky in the emulator, but worthwhile, no?

Yes, agree. Will go for accessors.

Thanks.