From mboxrd@z Thu Jan  1 00:00:00 1970
From: Muli Ben-Yehuda <muli@il.ibm.com>
Subject: Re: [PATCH] KVM: PCIPT: VT-d: Check if context mapping succeed or
	not
Date: Mon, 23 Jun 2008 22:35:22 +0300
Message-ID: <20080623193522.GC6989@il.ibm.com>
References: <08DF4D958216244799FC84F3514D70F00185142C@pdsmsx415.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: amit.shah@qumranet.com, kvm@vger.kernel.org,
	Ben-Ami Yassour1 <BENAMI@il.ibm.com>
To: "Han, Weidong" <weidong.han@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mtagate1.de.ibm.com ([195.212.29.150]:49258 "EHLO
	mtagate1.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754436AbYFWTfm (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 23 Jun 2008 15:35:42 -0400
Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49])
	by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id m5NJZWKv182470
	for <kvm@vger.kernel.org>; Mon, 23 Jun 2008 19:35:32 GMT
Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com [9.149.165.229])
	by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m5NJZWXd3158040
	for <kvm@vger.kernel.org>; Mon, 23 Jun 2008 21:35:32 +0200
Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1])
	by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m5NJZVCG023848
	for <kvm@vger.kernel.org>; Mon, 23 Jun 2008 21:35:32 +0200
Content-Disposition: inline
In-Reply-To: <08DF4D958216244799FC84F3514D70F00185142C@pdsmsx415.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi Weidong,

Minor comments below.

On Mon, Jun 23, 2008 at 10:53:17PM +0800, Han, Weidong wrote:


>  		printk("kvm_iommu_map_guest: domain = %p\n",
> kvm->arch.domain);
> -		
> +

This patch is line-wrapped, and there's some uneeded whitespace above.

>  	if (kvm_iommu_map_memslots(kvm)) {
>  		kvm_iommu_unmap_memslots(kvm);
>  		return -EFAULT;
>  	}
> -	kvm_intel_iommu_context_mapping(kvm->arch.domain, pdev);
> +
> +	if (kvm_intel_iommu_context_mapping(kvm->arch.domain, pdev)) {
> +		printk(KERN_ERR "Domain context map for %s failed",
> +		       pci_name(pdev));
> +		return -EFAULT;
> +	}

Why not return the return value from kvm_intel_iommu_context_mapping()
directly? It will make debugging a little bit easier.

Cheers,
Muli