Re: [GIT PULL] KVM fixes for 2.6.26-rc7

[Soren Hansen <soren@ubuntu.com>]

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

On Thu, Jun 26, 2008 at 04:00:20PM +0200, Gerd Hoffmann wrote:
> > The kernel modules shipped in 2.6.24 was causing all sorts of
> > issues, so in an effort to fix those, IIRC I grabbed what was in
> > 2.6.25 at the time and backported that, so if I were to get this
> > issue fixed, it should be sufficient to find anything that touches
> > the kvm clock ABI between 2.6.25-rc<whatever I used> and 2.6.25
> > final. Does that sound about right?
> guest side: turn off CONFIG_KVM_CLOCK for kernels older than -rc8 host
> side:  either apply the kvmclock fixes or disable support by removing
> kvm clock from the capabilities bit mask.

Thanks. This is very helpful!

I think disabling the kvm clock capability seems like the best option,
since a cursory inspection suggests that that would not break the ABI.
I'd have to run a test build to verify this, though.

>> I'm a bit confused about this, though. I was under the impression
>> that for the KVM_CLOCK stuff to work, it'd would have to be in the
>> host *and* the guest kernel, but our kernels don't have KVM_CLOCK
>> enabled at all?
> Host support doesn't depend on CONFIG_KVM_CLOCK.

Yeah, exactly. I didn't realise this until an hour ago.

Is this deliberately not ifdef'ed?

-- 
Soren Hansen               | 
Virtualisation specialist  | Ubuntu Server Team
Canonical Ltd.             | http://www.ubuntu.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]