From mboxrd@z Thu Jan 1 00:00:00 1970 From: Soren Hansen Subject: Re: [GIT PULL] KVM fixes for 2.6.26-rc7 Date: Thu, 26 Jun 2008 16:25:24 +0200 Message-ID: <20080626142524.GG21543@ralph.linux2go.dk> References: <48616182.9030902@qumranet.com> <20080625191723.GA20531@dmt.cnet> <48633511.8000403@redhat.com> <200806261045.57192.bernd-schubert@gmx.de> <48639027.2040607@codemonkey.ws> <4863911F.5090807@qumranet.com> <20080626134357.GE21543@ralph.linux2go.dk> <4863A0F4.5020101@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="j2AXaZ4YhVcLc+PQ" Cc: Avi Kivity , Anthony Liguori , Bernd Schubert , Marcelo Tosatti , kvm@vger.kernel.org To: Gerd Hoffmann Return-path: Received: from atlas.linux2go.dk ([88.198.22.52]:48513 "EHLO atlas.linux2go.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976AbYFZOZZ (ORCPT ); Thu, 26 Jun 2008 10:25:25 -0400 Content-Disposition: inline In-Reply-To: <4863A0F4.5020101@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: --j2AXaZ4YhVcLc+PQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 26, 2008 at 04:00:20PM +0200, Gerd Hoffmann wrote: > > The kernel modules shipped in 2.6.24 was causing all sorts of > > issues, so in an effort to fix those, IIRC I grabbed what was in > > 2.6.25 at the time and backported that, so if I were to get this > > issue fixed, it should be sufficient to find anything that touches > > the kvm clock ABI between 2.6.25-rc and 2.6.25 > > final. Does that sound about right? > guest side: turn off CONFIG_KVM_CLOCK for kernels older than -rc8 host > side: either apply the kvmclock fixes or disable support by removing > kvm clock from the capabilities bit mask. Thanks. This is very helpful! I think disabling the kvm clock capability seems like the best option, since a cursory inspection suggests that that would not break the ABI. I'd have to run a test build to verify this, though. >> I'm a bit confused about this, though. I was under the impression >> that for the KVM_CLOCK stuff to work, it'd would have to be in the >> host *and* the guest kernel, but our kernels don't have KVM_CLOCK >> enabled at all? > Host support doesn't depend on CONFIG_KVM_CLOCK. Yeah, exactly. I didn't realise this until an hour ago. Is this deliberately not ifdef'ed? --=20 Soren Hansen |=20 Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ --j2AXaZ4YhVcLc+PQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFIY6bUonjfXui9pOMRAtZWAJ9qlKyIiHaOFIkZciRQ3FzX8AT+IACfZHn9 oNf4af49WMpy8XjE40y62k0= =zS91 -----END PGP SIGNATURE----- --j2AXaZ4YhVcLc+PQ--