public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: [patch 3/3] KVM: VMX: handle segment limit granularity special case in software
Date: Wed, 16 Jul 2008 19:07:12 -0300	[thread overview]
Message-ID: <20080716221401.578260549@localhost.localdomain> (raw)
In-Reply-To: 20080716220709.886199616@localhost.localdomain

[-- Attachment #1: vmx-seg-limit-bits-0-11-zeroed --]
[-- Type: text/plain, Size: 1157 bytes --]

As the comment in the diff mentions, VMX does not accept any bit in
the range 11:0 of ES,CS,FS,GS,SS segment registers limit field to 
be zero with the granulity bit set to one.

So clear granularity and adjust the limit accordingly. 

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Index: kvm/arch/x86/kvm/vmx.c
===================================================================
--- kvm.orig/arch/x86/kvm/vmx.c
+++ kvm/arch/x86/kvm/vmx.c
@@ -1665,6 +1665,22 @@ static void vmx_set_segment(struct kvm_v
 		return;
 	}
 	vmcs_writel(sf->base, var->base);
+
+	/*
+ 	 * section 22.3.1.2:
+ 	 * - If any bit in the limit field in the range 11:0 is 0, G must be 0.
+ 	 * - If any bit in the limit field in the range 31:20 is 1, G must be 1.
+ 	 */
+	if (!vcpu->arch.rmode.active && !var->unusable &&
+	     seg != VCPU_SREG_TR && seg != VCPU_SREG_LDTR) {
+#define SEG_MASK ((1 << 12)-1)
+		if (var->g && (var->limit & SEG_MASK) != SEG_MASK) {
+			var->g = 0;
+			var->limit <<= 12;
+			var->limit |= SEG_MASK;
+		}
+	}
+
 	vmcs_write32(sf->limit, var->limit);
 	vmcs_write16(sf->selector, var->selector);
 	if (vcpu->arch.rmode.active && var->s) {

-- 


  parent reply	other threads:[~2008-07-16 22:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16 22:07 [patch 0/3] partially fix Windows reboot-via-triple-fault Marcelo Tosatti
2008-07-16 22:07 ` [patch 1/3] KVM: task switch: segment base is linear address Marcelo Tosatti
2008-07-16 22:07 ` [patch 2/3] KVM: task switch: use seg regs provided by subarch instead of reading from GDT Marcelo Tosatti
2008-07-16 22:07 ` Marcelo Tosatti [this message]
2008-07-17 10:03   ` [patch 3/3] KVM: VMX: handle segment limit granularity special case in software Avi Kivity
2008-07-17 12:43     ` Marcelo Tosatti
2008-07-17 13:20       ` Avi Kivity
2008-07-17 10:01 ` [patch 0/3] partially fix Windows reboot-via-triple-fault Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080716221401.578260549@localhost.localdomain \
    --to=mtosatti@redhat.com \
    --cc=avi@qumranet.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox