From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: [patch 2/3] KVM: task switch: check task busy state
Date: Sat, 19 Jul 2008 19:08:08 -0300 [thread overview]
Message-ID: <20080719220932.945706026@localhost.localdomain> (raw)
In-Reply-To: 20080719220806.152409866@localhost.localdomain
[-- Attachment #1: task-switch-checks --]
[-- Type: text/plain, Size: 1433 bytes --]
Checks that the new task is available (call, jump, exception, or interrupt) or
busy (IRET return). Generate GP# or TS# otherwise.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Index: kvm-vmx-checks/arch/x86/kvm/x86.c
===================================================================
--- kvm-vmx-checks.orig/arch/x86/kvm/x86.c
+++ kvm-vmx-checks/arch/x86/kvm/x86.c
@@ -3519,6 +3519,11 @@ int kvm_task_switch(struct kvm_vcpu *vcp
if (load_guest_segment_descriptor(vcpu, old_tss_sel, &cseg_desc))
goto out;
+ if (!nseg_desc.p || (nseg_desc.limit0 | nseg_desc.limit << 16) < 0x67) {
+ kvm_queue_exception_e(vcpu, TS_VECTOR, tss_selector & 0xfffc);
+ return 1;
+ }
+
if (reason != TASK_SWITCH_IRET) {
int cpl;
@@ -3527,12 +3532,19 @@ int kvm_task_switch(struct kvm_vcpu *vcp
kvm_queue_exception_e(vcpu, GP_VECTOR, 0);
return 1;
}
+ if (nseg_desc.type & (1 << 1)) {
+ kvm_queue_exception_e(vcpu, GP_VECTOR,
+ old_tss_sel & 0xfffc);
+ return 1;
+ }
+ } else {
+ if (!(cseg_desc.type & (1 << 1))) {
+ kvm_queue_exception_e(vcpu, TS_VECTOR,
+ tss_selector & 0xfffc);
+ return 1;
+ }
}
- if (!nseg_desc.p || (nseg_desc.limit0 | nseg_desc.limit << 16) < 0x67) {
- kvm_queue_exception_e(vcpu, TS_VECTOR, tss_selector & 0xfffc);
- return 1;
- }
if (reason == TASK_SWITCH_IRET || reason == TASK_SWITCH_JMP) {
cseg_desc.type &= ~(1 << 1); //clear the B flag
--
next prev parent reply other threads:[~2008-07-19 22:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 22:08 [patch 0/3] task switch fixes Marcelo Tosatti
2008-07-19 22:08 ` [patch 1/3] KVM: task switch: translate guest segment limit to virt-extension byte granular field Marcelo Tosatti
2008-07-20 9:22 ` Avi Kivity
2008-07-20 16:43 ` Marcelo Tosatti
2008-07-21 8:14 ` Avi Kivity
2008-07-19 22:08 ` Marcelo Tosatti [this message]
2008-07-19 22:08 ` [patch 3/3] KVM: task switch: check for segment base translation failure Marcelo Tosatti
2008-07-20 9:24 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080719220932.945706026@localhost.localdomain \
--to=mtosatti@redhat.com \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox