From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm <kvm@vger.kernel.org>, Olaf Schnapper <os@de.ibm.com>,
Carsten Otte <cotte@de.ibm.com>
Subject: [PATCH 2/6] kvm-s390: Fix guest kconfig
Date: Fri, 25 Jul 2008 15:50:04 +0200 [thread overview]
Message-ID: <200807251550.04423.borntraeger@de.ibm.com> (raw)
In-Reply-To: <200807251547.44296.borntraeger@de.ibm.com>
Cornelia Huck noticed that a modular virtio without kvm guest support
leads to a build error in the s390 virtio transport:
CONFIG_VIRTIO=m leads to
ERROR: "vmem_add_mapping" [drivers/s390/kvm/kvm_virtio.ko] undefined!
ERROR: "max_pfn" [drivers/s390/kvm/kvm_virtio.ko] undefined!
ERROR: "vmem_remove_mapping" [drivers/s390/kvm/kvm_virtio.ko] undefined!
The virtio transport only works with kvm guest support and only as a
builtin. Lets change the build process of drivers/s390/kvm/kvm_virtio.c
to depend on kvm guest support, which is also a bool.
CONFIG_S390_GUEST already selects CONFIG_VIRTIO, that should prevent
CONFIG_S390_GUEST=y CONFIG_VIRTIO=n situations.
CC: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
drivers/s390/kvm/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: kvm/drivers/s390/kvm/Makefile
===================================================================
--- kvm.orig/drivers/s390/kvm/Makefile
+++ kvm/drivers/s390/kvm/Makefile
@@ -6,4 +6,4 @@
# it under the terms of the GNU General Public License (version 2 only)
# as published by the Free Software Foundation.
-obj-$(CONFIG_VIRTIO) += kvm_virtio.o
+obj-$(CONFIG_S390_GUEST) += kvm_virtio.o
next prev parent reply other threads:[~2008-07-25 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 13:47 [PATCH 0/6] kvm-s390: Multiple fixes for kvm on s390 Christian Borntraeger
2008-07-25 13:49 ` [PATCH 1/6] kvm-s390: Advertise KVM_CAP_USER_MEMORY Christian Borntraeger
2008-07-25 13:50 ` Christian Borntraeger [this message]
2008-07-25 13:51 ` [PATCH 3/6] kvm-s390: Change guestaddr type in gaccess Christian Borntraeger
2008-07-25 13:51 ` [PATCH 4/6] kvm-s390: Fix program check on interrupt delivery handling Christian Borntraeger
2008-07-25 13:52 ` [PATCH 5/6] kvm-s390: Fix instruction naming for lctlg Christian Borntraeger
2008-07-25 13:53 ` [PATCH] kvm-s390: Fix possible host kernel bug on lctl(g) handling Christian Borntraeger
2008-07-27 7:49 ` [PATCH 0/6] kvm-s390: Multiple fixes for kvm on s390 Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807251550.04423.borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=avi@qumranet.com \
--cc=cotte@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=os@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox