From: Marcelo Tosatti <mtosatti@redhat.com>
To: Andrea Arcangeli <andrea@qumranet.com>
Cc: Avi Kivity <avi@qumranet.com>,
Marcelo Tosatti <marcelo.tosatti@cyclades.com.br>,
kvm@vger.kernel.org
Subject: Re: [PATCH 3/6] kvm.git allow browsing memslots with mmu_lock
Date: Mon, 28 Jul 2008 18:51:50 -0300 [thread overview]
Message-ID: <20080728215150.GB11486@dmt.cnet> (raw)
In-Reply-To: <20080725143203.GC8217@duo.random>
On Fri, Jul 25, 2008 at 04:32:03PM +0200, Andrea Arcangeli wrote:
> This allows reading memslots with only the mmu_lock hold for mmu
> notifiers that runs in atomic context and with mmu_lock held.
>
> Compared to previous versions I had to move this:
>
> - if (mem->slot >= kvm->nmemslots)
> - kvm->nmemslots = mem->slot + 1;
>
> after the call to kvm_arch_flush_shadow but that's ok as they're
> mutually exclusive: npages being null asks to remove the memslot and
> you can't remove a memslot that doesn't exist yet even if there's no
> explicit check that forbids it. In any case the ordering didn't seem
> meaningful if slots is set higher than nmemslots. But please Marcelo
> double check, thanks!
>
> Signed-off-by: Andrea Arcangeli <andrea@qumranet.com>
Looks good.
next prev parent reply other threads:[~2008-07-28 21:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 14:24 [PATCH 1/6] kvm.git mmu notifier patch Andrea Arcangeli
2008-07-25 14:26 ` [PATCH 2/6] kvm.git allow reading aliases with mmu_lock Andrea Arcangeli
2008-07-25 14:32 ` [PATCH 3/6] kvm.git allow browsing memslots " Andrea Arcangeli
2008-07-25 14:38 ` [PATCH 4/6] kvm-userland.git mmu notifier compat Andrea Arcangeli
2008-07-25 14:40 ` [PATCH 5/6] kvm.git handle reserved pages as mmio Andrea Arcangeli
2008-07-25 14:44 ` [PATCH 6/6] kvm.git allow reserved pages to be used as guest phys ram Andrea Arcangeli
2008-07-29 12:49 ` [PATCH 4/6] kvm-userland.git mmu notifier compat Avi Kivity
2008-07-29 13:03 ` Andrea Arcangeli
2008-07-29 13:30 ` Avi Kivity
2008-07-29 13:37 ` Andrea Arcangeli
2008-07-28 21:51 ` Marcelo Tosatti [this message]
2008-07-28 22:06 ` [PATCH 3/6] kvm.git allow browsing memslots with mmu_lock Andrea Arcangeli
2008-07-28 21:43 ` [PATCH 2/6] kvm.git allow reading aliases " Marcelo Tosatti
2008-07-28 21:11 ` [PATCH 1/6] kvm.git mmu notifier patch Marcelo Tosatti
2008-07-28 21:15 ` Marcelo Tosatti
2008-07-29 9:31 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080728215150.GB11486@dmt.cnet \
--to=mtosatti@redhat.com \
--cc=andrea@qumranet.com \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox