From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live migration
Date: Tue, 29 Jul 2008 19:18:54 +0100
Message-ID: <200807291918.55451.paul@codesourcery.com>
References: <488EBEFC.5040603@redhat.com> <fb249edb0807290659s2eaa6f45ue02abe5907f22128@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Cc: "andrzej zaborowski" <balrogg@gmail.com>, kvm@vger.kernel.org
To: qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail.codesourcery.com ([65.74.133.4]:34392 "EHLO
	mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753037AbYG2SS6 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 29 Jul 2008 14:18:58 -0400
In-Reply-To: <fb249edb0807290659s2eaa6f45ue02abe5907f22128@mail.gmail.com>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tuesday 29 July 2008, andrzej zaborowski wrote:
> 2008/7/29 Chris Lalancette <clalance@redhat.com>:
> > Attached is a simple patch to make i2c_bus_save() put a 32-bit quantity
> > in the save file, which matches what i2c_bus_load() expects to pull out
> > of the save file later.  Without this fix in place, KVM live migration
> > fails since the sender is only sending 1 byte while the receiver is
> > waiting to receive 4 bytes.
>
> Thanks, I committed this modified to use byte width afterall since the
> addresses are 7-bit quantities.

No they aren't. I2C also supports 10-bit addressing.

Paul