* [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target
@ 2008-08-13 3:48 Yang, Sheng
2008-08-18 1:59 ` Yang, Sheng
2008-08-18 10:10 ` Avi Kivity
0 siblings, 2 replies; 3+ messages in thread
From: Yang, Sheng @ 2008-08-13 3:48 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00 2001
From: Sheng Yang <sheng.yang@intel.com>
Date: Wed, 13 Aug 2008 11:35:17 +0800
Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target
Seems this flags is missing during merging long ago... And this result
in updating of libkvm.a didn't affect make process of qemu, which is
very puzzling...
Signed-off-by: Sheng Yang <sheng.yang@intel.com>
---
qemu/Makefile.target | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu/Makefile.target b/qemu/Makefile.target
index f4df081..c09af57 100644
--- a/qemu/Makefile.target
+++ b/qemu/Makefile.target
@@ -741,7 +741,7 @@ firmware.o: firmware.c
$(CC) $(HELPER_CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -c -o $@ $<
endif
-$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a
+$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(DEPLIBS)
$(CC) $(LDFLAGS) -o $@ $^ $(LIBS) $(SDL_LIBS) $(COCOA_LIBS)
$(CURSES_LIBS) $(BRLAPI_LIBS) $(VDE_LIBS)
endif # !CONFIG_USER_ONLY
--
1.5.4.5
[-- Attachment #2: 0001-kvm-qemu-Add-missing-DEPLIBS-in-Makefile.target.patch --]
[-- Type: text/x-diff, Size: 1061 bytes --]
From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00 2001
From: Sheng Yang <sheng.yang@intel.com>
Date: Wed, 13 Aug 2008 11:35:17 +0800
Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target
Seems this flags is missing during merging long ago... And this result in
updating of libkvm.a didn't affect make process of qemu, which is very
puzzling...
Signed-off-by: Sheng Yang <sheng.yang@intel.com>
---
qemu/Makefile.target | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu/Makefile.target b/qemu/Makefile.target
index f4df081..c09af57 100644
--- a/qemu/Makefile.target
+++ b/qemu/Makefile.target
@@ -741,7 +741,7 @@ firmware.o: firmware.c
$(CC) $(HELPER_CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -c -o $@ $<
endif
-$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a
+$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(DEPLIBS)
$(CC) $(LDFLAGS) -o $@ $^ $(LIBS) $(SDL_LIBS) $(COCOA_LIBS) $(CURSES_LIBS) $(BRLAPI_LIBS) $(VDE_LIBS)
endif # !CONFIG_USER_ONLY
--
1.5.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target
2008-08-13 3:48 [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target Yang, Sheng
@ 2008-08-18 1:59 ` Yang, Sheng
2008-08-18 10:10 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Yang, Sheng @ 2008-08-18 1:59 UTC (permalink / raw)
To: kvm; +Cc: Avi Kivity
On Wednesday 13 August 2008 11:48:02 Yang, Sheng wrote:
> From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00
> 2001 From: Sheng Yang <sheng.yang@intel.com>
> Date: Wed, 13 Aug 2008 11:35:17 +0800
> Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target
>
> Seems this flags is missing during merging long ago... And this
> result in updating of libkvm.a didn't affect make process of qemu,
> which is very puzzling...
Avi, comments?
BTW: Commits 68439f0a742138188176f35bb606c4aa6b702fd3 drop this.
--
regards
Yang, Sheng
>
> Signed-off-by: Sheng Yang <sheng.yang@intel.com>
> ---
> qemu/Makefile.target | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu/Makefile.target b/qemu/Makefile.target
> index f4df081..c09af57 100644
> --- a/qemu/Makefile.target
> +++ b/qemu/Makefile.target
> @@ -741,7 +741,7 @@ firmware.o: firmware.c
> $(CC) $(HELPER_CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -c -o $@ $<
> endif
>
> -$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a
> +$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(DEPLIBS)
> $(CC) $(LDFLAGS) -o $@ $^ $(LIBS) $(SDL_LIBS) $(COCOA_LIBS)
> $(CURSES_LIBS) $(BRLAPI_LIBS) $(VDE_LIBS)
>
> endif # !CONFIG_USER_ONLY
> --
> 1.5.4.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target
2008-08-13 3:48 [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target Yang, Sheng
2008-08-18 1:59 ` Yang, Sheng
@ 2008-08-18 10:10 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2008-08-18 10:10 UTC (permalink / raw)
To: Yang, Sheng; +Cc: kvm
Yang, Sheng wrote:
> From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00 2001
> From: Sheng Yang <sheng.yang@intel.com>
> Date: Wed, 13 Aug 2008 11:35:17 +0800
> Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target
>
> Seems this flags is missing during merging long ago... And this result
> in updating of libkvm.a didn't affect make process of qemu, which is
> very puzzling...
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-18 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-13 3:48 [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target Yang, Sheng
2008-08-18 1:59 ` Yang, Sheng
2008-08-18 10:10 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox