From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH 1/1] kvm: qemu: Handle tap fds with IFF_VNET_HDR Date: Wed, 13 Aug 2008 17:28:38 +0100 Message-ID: <20080813162838.GV11789@redhat.com> References: <1218485535-877-1-git-send-email-markmc@redhat.com> <48A1957C.4070007@qumranet.com> <1218638393.29159.38.camel@muff> <48A30ABE.3040903@qumranet.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mark McLoughlin , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([66.187.233.31]:54852 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880AbYHMQ2l (ORCPT ); Wed, 13 Aug 2008 12:28:41 -0400 Content-Disposition: inline In-Reply-To: <48A30ABE.3040903@qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Aug 13, 2008 at 07:24:30PM +0300, Avi Kivity wrote: > Mark McLoughlin wrote: > >Okay, I've just sent a patch to add TUNGETIFF: > > > > http://marc.info/?l=linux-netdev&m=121863813904363 > > > >See below patch for how we'd use it. Don't apply this until the kernel > >patch is accepted, obviously. > > > > > > Please repost once that's in. > > >The -help string is what libvirt would use to detect whether qemu has > >support for this; clearly libvirt would also need to detect the > >availability of TUNGETIFF in the running kernel. > > > > > > Neat trick. It would be nice to have a formal qemu capabilities query, > like we have for kvm (and a proper forwards and backwards compatible > qemu monitor protocol, and...) s/neat trick/sick hack/ but it has been working reasonably well so far. We have maintained compat with QEMU from 0.8.0 onwards. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|