From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yang, Sheng" <sheng.yang@intel.com>
Subject: Re: [PATCH 2/2] KVM: Device assignemnt with VT-d
Date: Wed, 13 Aug 2008 17:38:25 +0800
Message-ID: <200808131738.25940.sheng.yang@intel.com>
References: <1218118487-7657-1-git-send-email-benami@il.ibm.com> <1218118487-7657-2-git-send-email-benami@il.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Cc: Ben-Ami Yassour <benami@il.ibm.com>, avi@qumranet.com,
	amit.shah@qumranet.com, muli@il.ibm.com, weidong.han@intel.com,
	"Kay, Allen M" <allen.m.kay@intel.com>
To: kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga11.intel.com ([192.55.52.93]:22943 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752617AbYHMJf2 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 13 Aug 2008 05:35:28 -0400
In-Reply-To: <1218118487-7657-2-git-send-email-benami@il.ibm.com>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thursday 07 August 2008 22:14:47 Ben-Ami Yassour wrote:
> Based on a patch by: Kay, Allen M <allen.m.kay@intel.com>
>
> This patch enables pci device assignment based on VT-d support.
> When a device is assigned to the guest, the guest memory is pinned
> and the mapping is updated in the VT-d IOMMU.
>

I am afraid there still some compatible problem...

> Signed-off-by: Kay, Allen M <allen.m.kay@intel.com>
> Signed-off-by: Weidong Han <weidong.han@intel.com>
> Signed-off-by: Ben-Ami Yassour <benami@il.ibm.com>
> ---
>  arch/x86/kvm/Makefile      |    3 +
>  arch/x86/kvm/vtd.c         |  203
[snip]
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index a97157c..5cfc21a 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -35,6 +35,7 @@
>  #include <linux/module.h>
>  #include <linux/mman.h>
>  #include <linux/highmem.h>
> +#include <linux/intel-iommu.h>

This broken external kernel modules before 2.6.27... If we wrapped it 
with CONFIG_DMAR, it would also broken the commit before the patch 
checked in and after DMAR enabled in kernel... Need a version number 
judgement?

> diff --git a/include/asm-x86/kvm_host.h
> b/include/asm-x86/kvm_host.h index ef019b5..b141949 100644
> --- a/include/asm-x86/kvm_host.h
> +++ b/include/asm-x86/kvm_host.h
> @@ -354,6 +354,7 @@ struct kvm_arch{
>  	 */
>  	struct list_head active_mmu_pages;
>  	struct list_head assigned_dev_head;
> +	struct dmar_domain *intel_iommu_domain;

Need wrapped by CONFIG_DMAR?

-- 
regards
Yang, Sheng