Re: SR-IOV: patches are available for Linux kernel [4/4]

[Greg KH <greg@kroah.com>]

On Thu, Aug 14, 2008 at 03:50:26PM +0800, Zhao, Yu wrote:
> On Thursday, August 14, 2008 7:46 AM, Greg KH <mailto:greg@kroah.com> wrote:
> > On Wed, Aug 13, 2008 at 01:09:16PM -0700, Randy Dunlap wrote:
> >> On Tue, 12 Aug 2008 16:46:39 +0800 Zhao, Yu wrote:
> >> 
> >>> [PATCH 4/4] PCI: document SR-IOV
> >>> 
> >>> SR-IOV Documentation.
> >>> 
> >>> Signed-off-by: Yu Zhao <yu.zhao@intel.com>
> >>> Signed-off-by:  Eddie Dong <eddie.dong@intel.com>
> >>> 
> >>> ---
> >>>  Documentation/ABI/testing/sysfs-bus-pci |   13 ++
> >>>  Documentation/PCI/00-INDEX              |    2
> >>>  Documentation/PCI/pci-iov-howto.txt     |  170
> > +++++++++++++++++++++++++++++++
> >>>  3 files changed, 185 insertions(+), 0 deletions(-)
> >>> 
> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-pci
> > b/Documentation/ABI/testing/sysfs-bus-pci
> >>> index ceddcff..9ada27b 100644
> >>> --- a/Documentation/ABI/testing/sysfs-bus-pci
> >>> +++ b/Documentation/ABI/testing/sysfs-bus-pci
> >>> @@ -9,3 +9,16 @@ Description:
> >>>  		that some devices may have malformatted data.  If the
> >>>  		underlying VPD has a writable section then the
> >>>  		corresponding section of this file will be writable. +
> >>> +What:		/sys/bus/pci/devices/.../iov
> >>> +Date:		August 2008
> >>> +Contact:	Yu Zhao <yu.zhao@intel.com>
> >>> +Description:
> >>> +		This file will appear when SR-IOV capability is enabled
> >>> +		by the device driver if supported. It holds number of
> >>> +		available Virtual Functions and Bus, Device, Function
> >>> +		number and status of these Virtual Functions that belong
> >>> +		to this device (Physical Function). This file can be
> >> 
> >> This one file contains available VFs, Bus:dev:Func number, and
> >> status? Sounds like a misuse (abuse) of sysfs "one value per file"
> >> mantra, but I'll read below to see how it's done.
> >> 
> >> [added GregKH to cc: list]
> > 
> > I agree, why not just display the device tree of available devices
> > like all other busses do? 
> > 
> 
> Thanks for the comments. 
> 
> Will separate this file to
> /sys/bus/pci/devices/.../iov/{NumVFs,VF1,VF2,...}. The NumVFs file
> contains number of available VFs, and each VF file contains
> "bus:dev.func=status". Sounds better?

That sounds better yes.

Please use a 'struct device' for this as well, not a "raw" kobject.

thanks,

greg k-h