From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Sheng" Subject: Re: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target Date: Mon, 18 Aug 2008 09:59:13 +0800 Message-ID: <200808180959.13438.sheng.yang@intel.com> References: <200808131148.02834.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Avi Kivity To: kvm@vger.kernel.org Return-path: Received: from mga09.intel.com ([134.134.136.24]:56776 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbYHRB5V (ORCPT ); Sun, 17 Aug 2008 21:57:21 -0400 In-Reply-To: <200808131148.02834.sheng.yang@intel.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Wednesday 13 August 2008 11:48:02 Yang, Sheng wrote: > From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00 > 2001 From: Sheng Yang > Date: Wed, 13 Aug 2008 11:35:17 +0800 > Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target > > Seems this flags is missing during merging long ago... And this > result in updating of libkvm.a didn't affect make process of qemu, > which is very puzzling... Avi, comments? BTW: Commits 68439f0a742138188176f35bb606c4aa6b702fd3 drop this. -- regards Yang, Sheng > > Signed-off-by: Sheng Yang > --- > qemu/Makefile.target | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu/Makefile.target b/qemu/Makefile.target > index f4df081..c09af57 100644 > --- a/qemu/Makefile.target > +++ b/qemu/Makefile.target > @@ -741,7 +741,7 @@ firmware.o: firmware.c > $(CC) $(HELPER_CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -c -o $@ $< > endif > > -$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a > +$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(DEPLIBS) > $(CC) $(LDFLAGS) -o $@ $^ $(LIBS) $(SDL_LIBS) $(COCOA_LIBS) > $(CURSES_LIBS) $(BRLAPI_LIBS) $(VDE_LIBS) > > endif # !CONFIG_USER_ONLY > -- > 1.5.4.5