From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] Work around dhclient brokenness
Date: Tue, 19 Aug 2008 19:08:23 +1000
Message-ID: <200808191908.23665.rusty@rustcorp.com.au>
References: <1218829632-19037-1-git-send-email-aliguori@us.ibm.com> <20080819051355.GA8013@puku.stupidest.org> <20080819051708.GA29881@gondor.apana.org.au>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Chris Wedgwood <cw@f00f.org>, Avi Kivity <avi@qumranet.com>,
	Anthony Liguori <aliguori@us.ibm.com>, kvm@vger.kernel.org,
	Mark McLoughlin <markmc@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:58712 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750887AbYHSJIf (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 19 Aug 2008 05:08:35 -0400
In-Reply-To: <20080819051708.GA29881@gondor.apana.org.au>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tuesday 19 August 2008 15:17:08 Herbert Xu wrote:
> On Mon, Aug 18, 2008 at 10:13:55PM -0700, Chris Wedgwood wrote:
> > CSUM2 sounds so ugly though.  Features seem to get added and never
> > removed....  how about if this had a documented short lifetime (if it
> > really must go in)?
>
> All we need is a simple toggle to disable checksum offload.  Every
> NIC that offers receive checksum offload allows it to be disabled.
> virtio shouldn't be any different.
>
> Resetting the NIC seems a bit over the top.

Not really.  We could extend the protocol, but that's currently how feature 
negotiation works: you can't do it while the device is live.  That seemed 
simplest.  I learnt from Xen :)

(Of course, we don't need to *disable* it, we need to *enable* it).

Cheers,
Rusty.