Re: [PATCH] Work around dhclient brokenness

Rusty Russell
2008-08-19T11:39:05Z

On Tuesday 19 August 2008 19:56:13 Herbert Xu wrote:
> On Tue, Aug 19, 2008 at 07:08:23PM +1000, Rusty Russell wrote:
> > Not really. We could extend the protocol, but that's currently how
> > feature negotiation works: you can't do it while the device is live.
> > That seemed simplest. I learnt from Xen :)
> >
> > (Of course, we don't need to *disable* it, we need to *enable* it).
>
> I don't see why we shouldn't support disabling it. After all, any
> NIC that supports receive checksum offload allows it to be disabled.

Yes, we might as well support both. But you said we need to disable it,
whereas in fact we need to enable it (for this immediate problem).

I was being pedantic because some people are getting themselves very confused
here :)

Rusty.