From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] Work around dhclient brokenness
Date: Tue, 19 Aug 2008 19:10:44 +1000
Message-ID: <200808191910.45148.rusty@rustcorp.com.au>
References: <1218829632-19037-1-git-send-email-aliguori@us.ibm.com> <20080819051708.GA29881@gondor.apana.org.au> <20080819052840.GA8327@puku.stupidest.org>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Avi Kivity <avi@qumranet.com>,
	Anthony Liguori <aliguori@us.ibm.com>, kvm@vger.kernel.org,
	Mark McLoughlin <markmc@redhat.com>
To: Chris Wedgwood <cw@f00f.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:56061 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751609AbYHSJNf (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 19 Aug 2008 05:13:35 -0400
In-Reply-To: <20080819052840.GA8327@puku.stupidest.org>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tuesday 19 August 2008 15:28:40 Chris Wedgwood wrote:
> On Tue, Aug 19, 2008 at 03:17:08PM +1000, Herbert Xu wrote:
> > All we need is a simple toggle to disable checksum offload.  Every
> > NIC that offers receive checksum offload allows it to be disabled.
> > virtio shouldn't be any different.
>
> So why CSUM2 and not an ethtool interface then?

We need both.  CSUM2 is the new virtio-level feature.  The ethtool interface 
allows you to toggle it (we don't support that currently, but that's simply 
slackness).

Rusty.