From: Rusty Russell <rusty@rustcorp.com.au>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Chris Wedgwood <cw@f00f.org>, Avi Kivity <avi@qumranet.com>,
Anthony Liguori <aliguori@us.ibm.com>,
kvm@vger.kernel.org, Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH] Work around dhclient brokenness
Date: Tue, 19 Aug 2008 21:36:48 +1000 [thread overview]
Message-ID: <200808192136.49038.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080819095613.GA29653@gondor.apana.org.au>
On Tuesday 19 August 2008 19:56:13 Herbert Xu wrote:
> On Tue, Aug 19, 2008 at 07:08:23PM +1000, Rusty Russell wrote:
> > Not really. We could extend the protocol, but that's currently how
> > feature negotiation works: you can't do it while the device is live.
> > That seemed simplest. I learnt from Xen :)
> >
> > (Of course, we don't need to *disable* it, we need to *enable* it).
>
> I don't see why we shouldn't support disabling it. After all, any
> NIC that supports receive checksum offload allows it to be disabled.
Yes, we might as well support both. But you said we need to disable it,
whereas in fact we need to enable it (for this immediate problem).
I was being pedantic because some people are getting themselves very confused
here :)
Rusty.
next prev parent reply other threads:[~2008-08-19 11:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 19:47 [PATCH] Work around dhclient brokenness Anthony Liguori
2008-08-18 10:56 ` Avi Kivity
2008-08-18 11:01 ` Herbert Xu
2008-08-18 11:06 ` Avi Kivity
2008-08-18 11:34 ` Herbert Xu
2008-08-18 11:40 ` Avi Kivity
2008-08-18 11:44 ` Herbert Xu
2008-08-18 12:15 ` Avi Kivity
2008-08-19 0:45 ` Rusty Russell
2008-08-19 3:17 ` Chris Wedgwood
2008-08-19 4:41 ` Rusty Russell
2008-08-19 5:13 ` Chris Wedgwood
2008-08-19 5:17 ` Herbert Xu
2008-08-19 5:28 ` Chris Wedgwood
2008-08-19 9:10 ` Rusty Russell
2008-08-19 15:05 ` Chris Wedgwood
2008-08-25 4:01 ` Rusty Russell
2008-08-19 9:08 ` Rusty Russell
2008-08-19 9:56 ` Herbert Xu
2008-08-19 11:36 ` Rusty Russell [this message]
2008-08-19 23:35 ` Anthony Liguori
2008-08-19 9:12 ` Avi Kivity
2008-08-19 13:42 ` Anthony Liguori
2008-08-19 13:50 ` Avi Kivity
2008-08-19 13:54 ` Anthony Liguori
2008-08-19 14:00 ` Avi Kivity
2008-08-24 8:39 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808192136.49038.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=aliguori@us.ibm.com \
--cc=avi@qumranet.com \
--cc=cw@f00f.org \
--cc=herbert@gondor.apana.org.au \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox