From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [patch 0/2] do not run halted vcpu's
Date: Tue, 19 Aug 2008 20:07:26 -0300
Message-ID: <20080819230726.GA5157@dmt.cnet>
References: <20080801230912.013317832@localhost.localdomain> <48A2BB11.2020909@qumranet.com> <20080815001955.GB14844@dmt.cnet> <48A7C5AC.1020402@qumranet.com> <48A7D613.5030501@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Avi Kivity <avi@qumranet.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([66.187.233.31]:33510 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751940AbYHSXIH (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 19 Aug 2008 19:08:07 -0400
Content-Disposition: inline
In-Reply-To: <48A7D613.5030501@qumranet.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Aug 17, 2008 at 10:41:07AM +0300, Avi Kivity wrote:
> Avi Kivity wrote:
>> Marcelo Tosatti wrote:
>>> KVM: x86: do not execute halted vcpus
>>>
>>> Alright, need_resched was actually checked in vcpu_enter_guest, so this
>>> checks signal_pending too:
>>>
>>> Offline or uninitialized vcpu's can be executed if requested to perform
>>> userspace work.
>>> Follow Avi's suggestion to handle halted vcpu's in the main loop,
>>> simplifying kvm_emulate_halt(). Introduce a new vcpu->requests bit to
>>> indicate events that promote state from halted to running.
>>>
>>> Also standardize vcpu wake sites.
>>>   
>>
>> Applied, thanks.
>>
>
> This killed reboot, so I reverted it.

Works for me (both UP/SMP, Windows/Linux, guest initiated/system_reset),
and can't find anything obvious in the diff.

How can it be reproduced?