Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guests

[Muli Ben-Yehuda <muli@il.ibm.com>]

On Wed, Aug 27, 2008 at 03:48:54PM +0300, Ben-Ami Yassour1 wrote:

> On Tue, 2008-08-26 at 18:29 +0300, Amit Shah wrote:

> > From: Or Sagi <ors@tutis.com>
> > From: Nir Peleg <nir@tutis.com>
> > From: Amit Shah <amit.shah@qumranet.com>
> > From: Ben-Ami Yassour <benami@il.ibm.com>
> > From: Glauber de Oliveira Costa <gcosta@redhat.com>

Hey Amit,

In addition to Ben's other comments, note that git only uses the first
From: line as the author of the patch, and the rest are meaningless
from git's point of view. With a patch such as this where there were
multiple authors, I would pick one person (whoever wrote the bulk of
the patch) as the author, and then acknowledge the rest in the
changelog comment, "based on a patch by ...", etc.

Also, if that person's patch had a Signed-off by, you should include
that too. Or at least that's how I understand it.

Cheers,
Muli
-- 
Workshop on I/O Virtualization (WIOV '08)
Co-located with OSDI '08, Dec 2008, San Diego, CA
http://www.usenix.org/wiov08