From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guests Date: Wed, 27 Aug 2008 16:46:40 +0300 Message-ID: <20080827134640.GI9719@il.ibm.com> References: <1219764544-29764-1-git-send-email-amit.shah@qumranet.com> <1219764544-29764-2-git-send-email-amit.shah@qumranet.com> <1219841334.25626.55.camel@cluwyn.haifa.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@qumranet.com, kvm@vger.kernel.org, anthony@codemonkey.ws, weidong.han@intel.com, allen.m.kay@intel.com, Ben-Ami Yassour1 To: Amit Shah Return-path: Received: from mtagate5.de.ibm.com ([195.212.29.154]:52964 "EHLO mtagate5.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756620AbYH0NsM (ORCPT ); Wed, 27 Aug 2008 09:48:12 -0400 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m7RDkovU036726 for ; Wed, 27 Aug 2008 13:46:50 GMT Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com [9.149.165.229]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m7RDkn294002020 for ; Wed, 27 Aug 2008 15:46:49 +0200 Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m7RDkkkD029726 for ; Wed, 27 Aug 2008 15:46:46 +0200 Content-Disposition: inline In-Reply-To: <1219841334.25626.55.camel@cluwyn.haifa.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Aug 27, 2008 at 03:48:54PM +0300, Ben-Ami Yassour1 wrote: > On Tue, 2008-08-26 at 18:29 +0300, Amit Shah wrote: > > From: Or Sagi > > From: Nir Peleg > > From: Amit Shah > > From: Ben-Ami Yassour > > From: Glauber de Oliveira Costa Hey Amit, In addition to Ben's other comments, note that git only uses the first From: line as the author of the patch, and the rest are meaningless from git's point of view. With a patch such as this where there were multiple authors, I would pick one person (whoever wrote the bulk of the patch) as the author, and then acknowledge the rest in the changelog comment, "based on a patch by ...", etc. Also, if that person's patch had a Signed-off by, you should include that too. Or at least that's how I understand it. Cheers, Muli -- Workshop on I/O Virtualization (WIOV '08) Co-located with OSDI '08, Dec 2008, San Diego, CA http://www.usenix.org/wiov08