From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: MADV_DONTFORK undeclared
Date: Thu, 28 Aug 2008 11:22:26 -0300
Message-ID: <20080828142226.GA7998@dmt.cnet>
References: <E88155B5BD67CE4D87A3F1F70950B96A2FFC5D@berta.maurer-it.com> <42DFA526FC41B1429CE7279EF83C6BDC0188F398@pdsmsx415.ccr.corp.intel.com> <E88155B5BD67CE4D87A3F1F70950B96A2FFC5E@berta.maurer-it.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Zhang, Xiantao" <xiantao.zhang@intel.com>, kvm@vger.kernel.org
To: Dietmar Maurer <dietmar@proxmox.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([66.187.233.31]:42604 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752304AbYH1OXP (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 28 Aug 2008 10:23:15 -0400
Content-Disposition: inline
In-Reply-To: <E88155B5BD67CE4D87A3F1F70950B96A2FFC5E@berta.maurer-it.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Aug 28, 2008 at 01:06:13PM +0200, Dietmar Maurer wrote:
> Well, I guess I need to update my kernel headers 
>
> > Dietmar Maurer wrote:
> > > Compiling latest version 74 give me (on debian 4.0):
> > > 
> > > /home/dietmar/pve/pve-kvm-2.6.24/kvm-74/qemu/qemu-kvm.c: In function
> > > 'kvm_setup_guest_memory':
> > > /home/dietmar/pve/pve-kvm-2.6.24/kvm-74/qemu/qemu-kvm.c:821: error:
> > > 'MADV_DONTFORK' undeclared (first use in this function)
> > > /home/dietmar/pve/pve-kvm-2.6.24/kvm-74/qemu/qemu-kvm.c:821: error:
> > > (Each undeclared identifier is reported only once
> > > /home/dietmar/pve/pve-kvm-2.6.24/kvm-74/qemu/qemu-kvm.c:821: error:
> > > for each function it appears in.)
> > 
> > MADV_DONTFORK should be a new advice type for madvise, so it 
> > isn't declared in older header files. 
> > 
> > Avi, maybe you should add the stuff to solve the OS 
> > compatibility issues.  

Sorry, my bad.

Just comment that madvise(MADV_DONTFORK) call out for now, will post
a compat patch soon.