From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: VT-d support for device assignment Date: Mon, 1 Sep 2008 15:08:37 +0200 Message-ID: <20080901130837.GE4895@8bytes.org> References: <1219389054-15332-1-git-send-email-amit.shah@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@qumranet.com, kvm@vger.kernel.org, muli@il.ibm.com, anthony@codemonkey.ws, jesse.barnes@intel.com, david.woodhouse@intel.com, mark.gross@intel.com, benami@il.ibm.com, weidong.han@intel.com To: Amit Shah Return-path: Received: from 8bytes.org ([88.198.83.132]:58389 "EHLO 8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbYIANIj (ORCPT ); Mon, 1 Sep 2008 09:08:39 -0400 Content-Disposition: inline In-Reply-To: <1219389054-15332-1-git-send-email-amit.shah@qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Aug 22, 2008 at 10:10:52AM +0300, Amit Shah wrote: > > The following two patches contain VT-d support for device assignment > for KVM guests. > > The first patch contains the changes that are required to the generic > VT-d code. > > The second patch contains the changes to KVM. > > I've updated the 2nd patch to use VT-d only when requested by a parameter > on the command line, making it easier to support iommu with pvdma and > multiple iommu types. > > The command line currently should be invoked as: > > -pcidevice dev=00:13.0,vtd=on I don't like the vtd=on flag. I think its not good to have seperate parameters for Intel and AMD IOMMUs. So I think a parameter called iommu=on is the better choice. Joerg