Re: [patch 00/13] RFC: out of sync shadow

Avi Kivity
2008-09-08T14:56:17Z

Marcelo Tosatti wrote:
> On Sun, Sep 07, 2008 at 02:22:47PM +0300, Avi Kivity wrote:
>
>>> VMX "bypass_guest_pf" feature on prefetch_page breaks it (since new
>>> PTE writes need no TLB flush, I assume). Not sure if its worthwhile to
>>> convert notrap_nonpresent -> trap_nonpresent on unshadow or just go
>>> for unconditional nonpaging_prefetch_page.
>>>
>>>
>>>
>> Doesn't it kill bypass_guest_pf completely? As soon as we unsync a
>> page, we can't have nontrapping nonpresent ptes in it.
>>
>
> Yes, thats what I meant.
>
>

We can convert those ptes during unsync, and back during resync. That's
a fairly cheap operation.

--
error compiling committee.c: too many arguments to function