public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Jackson <iggy@theiggy.com>
To: Ben Bucksch <news@bucksch.org>
Cc: kvm@vger.kernel.org
Subject: Re: kvm userland: configure does not check for gawk
Date: Tue, 9 Sep 2008 23:16:03 -0500	[thread overview]
Message-ID: <200809092316.03261.iggy@theiggy.com> (raw)
In-Reply-To: <48C73BB4.7040900@bucksch.org>

Maybe something like this is in order:

diff --git a/configure b/configure
index 3bb10ce..efbfa24 100755
--- a/configure
+++ b/configure
@@ -102,6 +102,11 @@ if [ "$arch" = "powerpc" ]; then
     qemu_ldflags="$qemu_ldflags -L $PWD/libfdt"
 fi

+# check for some utils we use
+if [ -d .git -a ! -x "`which gawk`" ] ; then
+    echo "gawk not installed and necessary for compiling from git"
+fi
+
 #configure user dir
 (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir" \
           --arch="$arch" \


On Tuesday 09 September 2008 10:15:00 pm Ben Bucksch wrote:
> If gawk is not installed, the build reports "gawk not found", but then
> fails with strange errors about kvm.h having the wrong version, mismatch
> between kernel and userland, and even more resulting errors later on.
> This sent me off the wrong trail.
>
> Please:
>
>    1. Check that all apps used in the build process are checked in
>       configure and reported right there. Esp. gawk in this case.
>    2. Improve the version check to not say "version mismatch" when the
>       kvm.h file does not exist at all or is entirely empty, i.e.
>       KVM_API_VERSION is empty.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2008-09-10  4:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10  3:15 kvm userland: configure does not check for gawk Ben Bucksch
2008-09-10  4:16 ` Brian Jackson [this message]
2008-09-10  4:21   ` Brian Jackson
2008-09-13  5:15     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809092316.03261.iggy@theiggy.com \
    --to=iggy@theiggy.com \
    --cc=kvm@vger.kernel.org \
    --cc=news@bucksch.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox