Re: [Qemu-devel] [PATCH 2/10] Allow the monitor to be suspended during non-blocking op

Anthony Liguori
2008-09-10T13:12:27Z

Daniel P. Berrange wrote:
> On Tue, Sep 09, 2008 at 02:49:54PM -0500, Anthony Liguori wrote:
>
>> Live migration happens in the background, but it is useful to make the monitor
>> command appear as if it's blocking. This allows a management tool to
>> immediately know when the live migration has completed without having to poll
>> the migration status.
>>
>> This patch allows the monitor to be suspended from a monitor callback which
>> will prevent new monitor commands from being executed.
>>
>
> If I'm understanding this correctly, this will cause the monitor to silently
> drop & ignore any commands issued ?

No. It's just like if a monitor command took a really long time.

Regards,

Anthony Liguori

> Might it be better to have it print a
> reply on the monitor along the lines of 'command not allowed while migration
> is in progress' so people/apps interacting with the monitor understand why
> it is not doing what they ask it to.
>
> Daniel
>