Re: [Qemu-devel] [PATCH 2/10] Allow the monitor to be suspended during non-blocking op

Daniel P. Berrange
2008-09-10T10:02:36Z

On Tue, Sep 09, 2008 at 02:49:54PM -0500, Anthony Liguori wrote:
> Live migration happens in the background, but it is useful to make the monitor
> command appear as if it's blocking. This allows a management tool to
> immediately know when the live migration has completed without having to poll
> the migration status.
>
> This patch allows the monitor to be suspended from a monitor callback which
> will prevent new monitor commands from being executed.

If I'm understanding this correctly, this will cause the monitor to silently
drop & ignore any commands issued ? Might it be better to have it print a
reply on the monitor along the lines of 'command not allowed while migration
is in progress' so people/apps interacting with the monitor understand why
it is not doing what they ask it to.

Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|