From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 3/10] Add bdrv_flush_all()
Date: Wed, 10 Sep 2008 17:37:17 +0100
Message-ID: <200809101737.18560.paul@codesourcery.com>
References: <1220989802-13706-1-git-send-email-aliguori@us.ibm.com> <5d6222a80809100746kd4bcf21h5c3fd9afbec1067d@mail.gmail.com> <48C7E579.5040702@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Glauber Costa <glommer@gmail.com>,
	Chris Wright <chrisw@redhat.com>,
	Uri Lublin <uri.lublin@qumranet.com>, kvm@vger.kernel.org
To: qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail.codesourcery.com ([65.74.133.4]:43538 "EHLO
	mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751028AbYIJQhV (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 10 Sep 2008 12:37:21 -0400
In-Reply-To: <48C7E579.5040702@us.ibm.com>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

> I'm actually liking bdrv_flush_all() less and less.  If there are any
> outstanding IO requests, it will increase the down time associated with
> live migration.  I think we definitely need to add a live save handler
> that waits until there are no outstanding IO requests to converge.  I'm
> concerned though that it's not totally unreasonable to expect a guest to
> always have an IO request in flight.  That leads me to think that maybe
> we should be cancelling outstanding requests, and somehow saving their
> state?

That's not possible with the current code because the IO callbacks 
(particularly when you start involving the SCSI layer) are generated 
dynamically.

Paul