RE: [PATCH 3/4 v2] PCI: support SR-IOV capability

Zhao, Yu
2008-09-10T07:37:06Z

On Monday, September 01, 2008 11:30 PM, Alex Chiang wrote:
>To: Zhao, Yu
>Cc: Jesse Barnes; linux-pci@vger.kernel.org; Randy Dunlap; Greg KH; Grant
>Grundler; Matthew Wilcox; linux-kernel@vger.kernel.org; kvm@vger.kernel.org;
>virtualization@lists.linux-foundation.org; xen-devel@lists.xensource.com
>Subject: Re: [PATCH 3/4 v2] PCI: support SR-IOV capability
>
>* Zhao, Yu <yu.zhao@intel.com>:
>> Support SR-IOV capability. By default, this feature is not enabled and the
>SR-IOV device behaves as traditional PCI device. After it's enabled, each
>Virtual Function's PCI configuration space can be accessed using its own Bus,
>Device and Function Number (Routing ID). Each Virtual Function also has PCI
>Memory Space, which is used to map its own register set.
>>
>> Signed-off-by: Yu Zhao <yu.zhao@intel.com>
>> Signed-off-by: Eddie Dong <eddie.dong@intel.com>
>>
>> ---
>> drivers/pci/Kconfig | 10 +
>> drivers/pci/Makefile | 2 +
>> drivers/pci/iov.c | 555
>++++++++++++++++++++++++++++++++++++++++++++++
>> drivers/pci/pci.c | 14 +-
>> drivers/pci/pci.h | 44 ++++
>> drivers/pci/probe.c | 5 +
>> include/linux/pci.h | 28 +++
>> include/linux/pci_regs.h | 20 ++
>> 8 files changed, 677 insertions(+), 1 deletions(-)
>> create mode 100644 drivers/pci/iov.c
>>
>> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
>> index f43cc46..0a1fe01 100644
>> --- a/drivers/pci/Kconfig
>> +++ b/drivers/pci/Kconfig
>> @@ -57,3 +57,13 @@ config PCI_ARI
>> default n
>> help
>> This enables PCI Alternative Routing-ID Interpretation.
>> +
>> +config PCI_IOV
>> + bool "PCI SR-IOV support"
>> + depends on PCI && HOTPLUG
>> + select PCI_MSI
>> + select PCI_ARI
>> + select HOTPLUG_PCI
>> + default n
>> + help
>> + This allows device drivers to enable Single Root I/O Virtualization.
>
>I'd like to see this Kconfig help text enhanced too. Telling a
>user that PCI_IOV enables Single Root I/O Virtualization isn't
>that helpful, but explaining what SR-IOV actually gets you _is_
>helpful.
>
> This option allows device drivers to enable Single Root I/O
> Virtualization. Each Virtual Function's PCI configuration
> space can be accessed using its own Bus, Device and Function
> Number (Routing ID). Each Virtual Function also has PCI Memory
> Space, which is used to map its own register set.

Will do this too in next version.

>
>Thanks.
>
>/ac