Re: [PATCH] KVM: VMX: Move private memory slot position

["Yang, Sheng" <sheng.yang@intel.com>]

On Thursday 04 September 2008 11:30:20 Yang, Sheng wrote:
> From ebe4ea311305d2910dcdcff2510662da0dc2c742 Mon Sep 17 00:00:00 2001
> From: Sheng Yang <sheng.yang@intel.com>
> Date: Thu, 4 Sep 2008 03:11:48 +0800
> Subject: [PATCH] KVM: VMX: Move private memory slot position
>
> PCI device assignment would map guest MMIO spaces as separate slot, so it
> is possible that the device has more than 2 MMIO spaces and overwrite
> current private memslot.
>
> The patch move private memory slot to the top of userspace visible memory
> slots.
>

Avi, these two?

(Oh, it's a little old, next time I will use git-send-email :) )
-- 
regards
Yang, Sheng

> Signed-off-by: Sheng Yang <sheng.yang@intel.com>
> ---
>  arch/x86/kvm/vmx.c |    2 +-
>  arch/x86/kvm/vmx.h |    5 +++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 004d24a..27c3bb7 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -2448,7 +2448,7 @@ static int vmx_set_tss_addr(struct kvm *kvm, unsigned
> int addr)
>  {
>  	int ret;
>  	struct kvm_userspace_memory_region tss_mem = {
> -		.slot = 8,
> +		.slot = TSS_PRIVATE_MEMSLOT,
>  		.guest_phys_addr = addr,
>  		.memory_size = PAGE_SIZE * 3,
>  		.flags = 0,
> diff --git a/arch/x86/kvm/vmx.h b/arch/x86/kvm/vmx.h
> index 16b3cfb..dd0eea9 100644
> --- a/arch/x86/kvm/vmx.h
> +++ b/arch/x86/kvm/vmx.h
> @@ -356,8 +356,9 @@ enum vmcs_field {
>  #define IA32_FEATURE_CONTROL_LOCKED_BIT		0x1
>  #define IA32_FEATURE_CONTROL_VMXON_ENABLED_BIT	0x4
>
> -#define APIC_ACCESS_PAGE_PRIVATE_MEMSLOT	9
> -#define IDENTITY_PAGETABLE_PRIVATE_MEMSLOT	10
> +#define TSS_PRIVATE_MEMSLOT			(KVM_MEMORY_SLOTS + 0)
> +#define APIC_ACCESS_PAGE_PRIVATE_MEMSLOT	(KVM_MEMORY_SLOTS + 1)
> +#define IDENTITY_PAGETABLE_PRIVATE_MEMSLOT	(KVM_MEMORY_SLOTS + 2)
>
>  #define VMX_NR_VPIDS				(1 << 16)
>  #define VMX_VPID_EXTENT_SINGLE_CONTEXT		1
> --
> 1.5.4.5