From: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
To: Avi Kivity <avi@qumranet.com>
Cc: Mohammed Gamal <m.gamal005@gmail.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] x86 emulator: Add call near absolute instruction (group5: opcode 0xff mod r/m 2)
Date: Fri, 12 Sep 2008 09:40:14 +0200 [thread overview]
Message-ID: <20080912094014.7eb73cda@frecb000711> (raw)
In-Reply-To: <48C68D57.9020105@qumranet.com>
On Tue, 09 Sep 2008 17:51:03 +0300
Avi Kivity <avi@qumranet.com> wrote:
> Guillaume Thouvenin wrote:
> > - case 0x38 ... 0x3d:
> > + case 0x38 ... 0x3b:
> > cmp: /* cmp */
> > emulate_2op_SrcV("cmp", c->src, c->dst, ctxt->eflags);
> > break;
> > + case 0x3c ... 0x3d: /* cmp al imm8 or ax imm16 or eax imm32 */
> > + c->dst.type = OP_REG;
> > + c->dst.bytes = c->op_bytes;
> > + c->dst.ptr = &c->regs[VCPU_REGS_RAX];
> > + if (c->op_bytes == 1)
> > + c->dst.val = *(u8 *)c->dst.ptr;
> > + else if (c->op_bytes == 2)
> > + c->dst.val = *(u16 *)c->dst.ptr;
> > + else
> > + c->dst.val = *(u32 *)c->dst.ptr;
> > + c->dst.orig_val = c->dst.val;
> > + goto cmp;
> >
>
> SrcAcc would remove the need for this change.
As I don't see SrcAcc in the source it means that you suggest to add a
new type of source operand right?
Guillaume
next prev parent reply other threads:[~2008-09-12 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 18:47 [PATCH] x86 emulator: Add call near absolute instruction (group5: opcode 0xff mod r/m 2) Mohammed Gamal
2008-09-09 7:16 ` Guillaume Thouvenin
2008-09-09 12:49 ` Mohammed Gamal
2008-09-10 9:31 ` Guillaume Thouvenin
2008-09-09 14:51 ` Avi Kivity
2008-09-09 17:05 ` Mohammed Gamal
2008-09-10 7:29 ` Avi Kivity
2008-09-12 7:40 ` Guillaume Thouvenin [this message]
2008-09-12 10:42 ` Mohammed Gamal
2008-09-10 15:31 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080912094014.7eb73cda@frecb000711 \
--to=guillaume.thouvenin@ext.bull.net \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox