From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: Re: [PATCH] KVM: Device Assignment with VT-d Date: Wed, 17 Sep 2008 06:56:05 +0300 Message-ID: <20080917035605.GB6966@il.ibm.com> References: <20080916005853.7876D250DB2@il.qumranet.com> <1221568935.4172.22.camel@frecb07144> <48CFF876.8000801@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Laurent Vivier , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mtagate1.de.ibm.com ([195.212.17.161]:58290 "EHLO mtagate1.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbYIQFfB (ORCPT ); Wed, 17 Sep 2008 01:35:01 -0400 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.1/8.13.1) with ESMTP id m8H5Ys22032200 for ; Wed, 17 Sep 2008 05:34:54 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m8H5YsEn3621058 for ; Wed, 17 Sep 2008 07:34:54 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m8H5YoPk011082 for ; Wed, 17 Sep 2008 07:34:50 +0200 Content-Disposition: inline In-Reply-To: <48CFF876.8000801@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Sep 16, 2008 at 11:18:30AM -0700, Avi Kivity wrote: > Laurent Vivier wrote: >>> @@ -1147,6 +1157,9 @@ int kvm_dev_ioctl_check_extension(long ext) >>> case KVM_CAP_PV_MMU: >>> r = !tdp_enabled; >>> break; >>> + case KVM_CAP_IOMMU: >>> + r = intel_iommu_found(); >>> + break; >>> >> >> Must depend on CONFIG_DMAR too >> > > Rather, intel_iommu_found() should be defined (and return zero) if > !CONFIG_DMAR. > > (what's a dmar?) "DMA Remapping" Cheers, Muli -- Workshop on I/O Virtualization (WIOV '08) Co-located with OSDI '08, Dec 2008, San Diego, CA http://www.usenix.org/wiov08