From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [patch 07/10] KVM: MMU: mmu_parent_walk Date: Sat, 20 Sep 2008 21:44:28 -0300 Message-ID: <20080921004428.GB10120@dmt.cnet> References: <20080918212749.800177179@localhost.localdomain> <20080918213336.976429470@localhost.localdomain> <48D44A4E.3070400@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org, "David S. Ahern" To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:40249 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbYIUApk (ORCPT ); Sat, 20 Sep 2008 20:45:40 -0400 Content-Disposition: inline In-Reply-To: <48D44A4E.3070400@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Sep 19, 2008 at 05:56:46PM -0700, Avi Kivity wrote: >> + } while (level > start_level-1); >> +} >> + > > Could be much simplified with recursion, no? As the depth is limited to > 4, there's no stack overflow problem. The early version was recursive, but since its a generic helper I preferred a non-recursive function.