From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [patch 10/10] KVM: MMU: speed up mmu_unsync_walk Date: Sat, 20 Sep 2008 21:45:40 -0300 Message-ID: <20080921004540.GD10120@dmt.cnet> References: <20080918212749.800177179@localhost.localdomain> <20080918213337.235766366@localhost.localdomain> <48D45160.6030208@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org, "David S. Ahern" To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:40281 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbYIUAqr (ORCPT ); Sat, 20 Sep 2008 20:46:47 -0400 Content-Disposition: inline In-Reply-To: <48D45160.6030208@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Sep 19, 2008 at 06:26:56PM -0700, Avi Kivity wrote: >> --- kvm.orig/include/asm-x86/kvm_host.h >> +++ kvm/include/asm-x86/kvm_host.h >> @@ -201,6 +201,7 @@ struct kvm_mmu_page { >> u64 *parent_pte; /* !multimapped */ >> struct hlist_head parent_ptes; /* multimapped, kvm_pte_chain */ >> }; >> + DECLARE_BITMAP(unsync_child_bitmap, 512); >> }; >> > > Later, we can throw this bitmap out to a separate object. Yeah. > Also, it may make sense to replace it with an array of u16s. Why?