Re: [patch 07/10] KVM: MMU: mmu_parent_walk

Avi Kivity
2008-09-22T20:30:52Z

Marcelo Tosatti wrote:
> On Fri, Sep 19, 2008 at 05:56:46PM -0700, Avi Kivity wrote:
>
>>> + } while (level > start_level-1);
>>> +}
>>> +
>>>
>> Could be much simplified with recursion, no? As the depth is limited to
>> 4, there's no stack overflow problem.
>>
>
> The early version was recursive, but since its a generic helper I
> preferred a non-recursive function.
>

Let's start with a super-simple recursive version. When the code has
seen some debugging, we can add complexity. But for the initial phase,
simpler is better.

The non-recursive version has the advantage that it can be converted to
a kvm_for_each_parent() later, but still, we can do that later.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.