From: Glauber Costa <glommer@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, aliguori@us.ibm.com
Subject: Re: [PATCH 5/9] add debuging facilities to memory registration at libkvm
Date: Mon, 22 Sep 2008 10:52:00 -0300 [thread overview]
Message-ID: <20080922135200.GD3618@poweredge.glommer> (raw)
In-Reply-To: <48D5424F.1020703@redhat.com>
On Sat, Sep 20, 2008 at 11:34:55AM -0700, Avi Kivity wrote:
> Glauber Costa wrote:
>> +#ifdef DEBUG_MEMREG
>> + fprintf(stderr, "%s, memory: gpa: %llx, size: %llx, uaddr: %llx, slot: %x, flags: %lx\n",
>> + __func__, memory.guest_phys_addr, memory.memory_size,
>> + memory.userspace_addr, memory.slot, memory.flags);
>> +#endif
>>
>
> Please wrap in a dprintf() macro or similar.
Consider it done.
>
>
> --
> I have a truly marvellous patch that fixes the bug which this
> signature is too narrow to contain.
>
next prev parent reply other threads:[~2008-09-22 13:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 16:08 [PATCHEY 0/9] Rrrreplace the ol' scurvy memory registration Glauber Costa
2008-09-19 16:08 ` [PATCH 1/9] Don't separate registrations with IO_MEM_ROM set Glauber Costa
2008-09-19 16:08 ` [PATCH 2/9] do not use mem_hole anymore Glauber Costa
2008-09-19 16:08 ` [PATCH 3/9] allow intersecting region to be on the boundary Glauber Costa
2008-09-20 18:32 ` Avi Kivity
2008-09-22 13:48 ` Glauber Costa
2008-09-23 10:30 ` Avi Kivity
2008-09-23 16:18 ` Glauber Costa
2008-09-19 16:08 ` [PATCH 4/9] substitute is_allocated_mem with more general is_containing_region Glauber Costa
2008-09-20 18:33 ` Avi Kivity
2008-09-22 13:51 ` Glauber Costa
2008-09-23 7:35 ` Avi Kivity
2008-09-23 16:19 ` Glauber Costa
2008-09-19 16:08 ` [PATCH 5/9] add debuging facilities to memory registration at libkvm Glauber Costa
2008-09-20 18:34 ` Avi Kivity
2008-09-22 13:52 ` Glauber Costa [this message]
2008-09-19 16:08 ` [PATCH 6/9] unregister memory area depending on their flags Glauber Costa
2008-09-19 16:08 ` [PATCH 7/9] register mmio slots Glauber Costa
2008-09-20 18:38 ` Avi Kivity
2008-09-22 13:55 ` Glauber Costa
2008-09-23 7:31 ` Avi Kivity
2008-09-23 16:48 ` Glauber Costa
2008-09-19 16:08 ` [PATCH 8/9] coalesce mmio regions with an explicit call Glauber Costa
2008-09-20 18:39 ` Avi Kivity
2008-09-22 13:56 ` Glauber Costa
2008-09-23 7:29 ` Avi Kivity
2008-09-23 16:22 ` Glauber Costa
2008-09-24 11:10 ` Avi Kivity
2008-09-24 21:59 ` Glauber Costa
2008-09-25 7:08 ` Avi Kivity
2008-09-25 11:19 ` Glauber Costa
2009-04-17 14:04 ` Dmitry Eremin-Solenikov
2008-09-19 16:08 ` [PATCH 9/9] move kvm memory registration inside qemu's Glauber Costa
2008-09-19 16:33 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080922135200.GD3618@poweredge.glommer \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).