From mboxrd@z Thu Jan  1 00:00:00 1970
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [PATCH 5/9] add debuging facilities to memory registration at
	libkvm
Date: Mon, 22 Sep 2008 10:52:00 -0300
Message-ID: <20080922135200.GD3618@poweredge.glommer>
References: <1221840506-22996-1-git-send-email-glommer@redhat.com> <1221840506-22996-6-git-send-email-glommer@redhat.com> <48D5424F.1020703@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, aliguori@us.ibm.com
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:47754 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752053AbYIVNwW (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 22 Sep 2008 09:52:22 -0400
Content-Disposition: inline
In-Reply-To: <48D5424F.1020703@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sat, Sep 20, 2008 at 11:34:55AM -0700, Avi Kivity wrote:
> Glauber Costa wrote:
>> +#ifdef DEBUG_MEMREG
>> +	fprintf(stderr, "%s, memory: gpa: %llx, size: %llx, uaddr: %llx, slot: %x, flags: %lx\n",
>> +		__func__, memory.guest_phys_addr, memory.memory_size,
>> +		memory.userspace_addr, memory.slot, memory.flags);
>> +#endif
>>   
>
> Please wrap in a dprintf() macro or similar.
Consider it done.

>
>
> -- 
> I have a truly marvellous patch that fixes the bug which this
> signature is too narrow to contain.
>