From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@qumranet.com>
Subject: Re: [PATCH 10/11] VMX: work around lacking VNMI support
Date: Mon, 22 Sep 2008 17:15:11 +0300
Message-ID: <20080922141511.GA25282@minantech.com>
References: <48D74CE6.5060008@siemens.com> <48D7504B.7050102@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm-devel <kvm@vger.kernel.org>,
	"Yang, Sheng" <sheng.yang@intel.com>, Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:36953 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752090AbYIVOPN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 22 Sep 2008 10:15:13 -0400
Content-Disposition: inline
In-Reply-To: <48D7504B.7050102@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Sep 22, 2008 at 09:59:07AM +0200, Jan Kiszka wrote:
> @@ -2356,6 +2384,19 @@ static void vmx_inject_nmi(struct kvm_vc
>  {
>  	struct vcpu_vmx *vmx = to_vmx(vcpu);
>  
> +	if (!cpu_has_virtual_nmis()) {
> +		/*
> +		 * Tracking the NMI-blocked state in software is built upon
> +		 * finding the next open IRQ window. This, in turn, depends on
> +		 * well-behaving guests: They have to keep IRQs disabled at
> +		 * least as long as the NMI handler runs. Otherwise we may
> +		 * cause NMI nesting, maybe breaking the guest. But as this is
> +		 * highly unlikely, we can live with the residual risk.
> +		 */
> +		vmx->soft_vnmi_blocked = 1;
> +		vmx->vnmi_blocked_time = 0;
> +	}
> +
We still get here with vmx->soft_vnmi_blocked = 1. Trying to find out
how.

--
			Gleb.