From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [patch 02/10] KVM: MMU: move local TLB flush to mmu_set_spte
Date: Mon, 22 Sep 2008 18:56:36 -0300
Message-ID: <20080922215636.GB27744@dmt.cnet>
References: <20080921001046.GA8593@dmt.cnet> <48D7FF7C.20808@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm-devel <kvm@vger.kernel.org>,
	"David S. Ahern" <daahern@cisco.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:55226 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754084AbYIVV5z (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 22 Sep 2008 17:57:55 -0400
Content-Disposition: inline
In-Reply-To: <48D7FF7C.20808@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Sep 22, 2008 at 11:26:36PM +0300, Avi Kivity wrote:
> Marcelo Tosatti wrote:
>
>   
>
>>> I think we had cases where the spte.pfn contents changed, for example 
>>>  when a large page was replaced by a normal page,
>>>     
>>
>> True. And the TLB is not flushed now for large->normal replace, in case
>> the pte thats faulting is read-only. The local (and remote) TLB's must
>> be flushed on large->normal replace.
>>
>>   
>
> Can you prepare a patch for that, for -stable?

First one in the v3 series.